[Libreoffice] leak per frame, mac input request.

[Norbert Thiebaud]

On Tue, Feb 1, 2011 at 5:47 AM, Caolán McNamara <caolanm at redhat.com> wrote:
> So, after clearing up a pile of circular ownership things to clear out
> deadwood blocking valgrind from telling me what I wanted to know I
> tracked down a a leak in framework/source/services/frame.cxx where for
> each frame we do a new WindowCommandDispatch, and the comment claims
> that the WindowCommandDispatch will release itself at frame destruction.
>
> It doesn't of course, its implemented as a uno XEventListener but
> doesn't register itself as a uno listener to the frame to even have a
> chance of doing the right thing. It itself registers itself as a vcl
> listener to the frame, and doesn't delete itself on OBJ_DYING.
>
> So, I could remove the XEventListener foo, add a delete this on
> OBJ_DYING to remove the leak.
>
> My open question though, is it that this WindowCommandDispatch exists
> apparently do bind some mac "About" and "Preferences" events to do the
> right thing on that platform. What's special about About/Preferences in
> Mac ?, and does it currently work correctly ?, i.e. its worth fixing
> this rather than removing it entirely.

Yes there is somethng special on Mac:
there is one menu bar only and it is at the top of the display.
it has a little apple icon as first menu, then a menu that is named
with the name of the application. in that later menu you should find
the About item and the Preference Item.

Norbert

>
> C.
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>