[Libreoffice] Should the Thesaurus/mythes use a precomputed index (installer file size)

Tor Lillqvist tlillqvist at novell.com
Wed Feb 2 03:56:05 PST 2011


> checking size of long... 0            !!!!!!

Yeah, that has been there for a while, it doesn't really matter, the configured SIZEOF_LONG isn't used in LibreOffice itself for anything.

The explanation to this mysterious thing is that it runs that size check using the MSVC compiler, because it has already been searching for what compiler to use when building LibreOffice, and decided (correctly) to use MSVC, and it has then set the CC variable to point to that.

But the necessary environment variables or compiler flags needed when compiling, or in this case actually linking, with MSVC has not been set up yet at that stage. As that happens only when winenv.set.sh is sourced when one actually starts to build LibreOffice.

Anyway, the SIZEOF_LONG is used only in dmake sources, and even there only if there is no SIZEOF_INT. And dmake is not to be built with MSVC anyway, it is built with Cygwin's gcc, and has its own configure script, that finds out the sizes of short, int and long.

So, the whole section

AC_CHECK_SIZEOF(long)
SIZEOF_LONG=$ac_cv_sizeof_long
AC_SUBST(SIZEOF_LONG)

in configure.in is probably completely unneeded. I will remove it and see if it breaks anything. Most likely there are lots of other unneeded stuff in configure.in, too.

--tml




More information about the LibreOffice mailing list