[Libreoffice] [PATCH] Get rid of SvBytes/SvSvULongs in SwUndoDelNum

Michael Meeks michael.meeks at novell.com
Mon Feb 7 07:30:33 PST 2011

Hi Nigel,

On Mon, 2011-02-07 at 14:33 +0000, Nigel Hawkins wrote:
> Oddly enough, I was looking at this the other day but didn't get round
> to submitting a patch because I couldn't get sw to compile (for totally
> unrelated reasons). My changes were almost identical to yours, though I
> have one suggestion.

	Drat; sorry to hear work got duplicated.

> Changing to a std::pair means we go from descriptively named items
> (aNodeIdx and aLevels) to the generic first/second. Which is less clear
> to the reader. Can I suggest you either:

	Perhaps you can build your patch on top of Andrey's to capture that
goodness ? I'm busy adding a few more easy hacks to try to make such
conflicts less likely: it can help to add your name and a date vs. an
easy hack (with perhaps a sub-portion of what you're working on).



 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list