[Libreoffice] [PATCH] [PUSHED] Removed unused functions and classes from calc 3last

[Caolán McNamara]

On Tue, 2011-02-08 at 21:17 -0500, Kohei Yoshida wrote:
> Hi Alfonso,
> 
> On Sun, 2011-02-06 at 19:08 +0000, Alfonso Eusebio wrote:

> > On a related note:
> > Several of the unused functions identified by call-catcher live in the addin 
> > "module" within calc (calc/sc/addin). These functions seem to be called 
> > indirectly by the function add-in mechanism.

yeah, callcatcher can't know that functions are called effectively
through dlopen/dlsym. C++ methods marked as unused are pretty much
guaranteed to be unused, unless maybe e.g. different platform or debug
mode vs non debug mode, but C methods might be dlsymed out. I keep a
whitelist of those, so if you can determine that some method is used
through some dlsym case mail them on to me and I'll add them to the
callcatcher whitelist thing.

C.