[Libreoffice] [PATCH] [PUSHED] Removed unused functions and classes from calc 3last
Alfonso Eusebio
alfonso_eusebio at yahoo.co.uk
Mon Feb 14 00:33:02 PST 2011
Hi Kohei,
I've prepared a patch that removes the addin functions from calc/addin.
These changes are made available under LGPLv3+/MPL.
> Wow. I never knew this (sc/addin) existed! And yes, it's also my
> understanding that scaddins is the right home for all the add-in
> functions.
>
> I can't be 100% certain of this. But if you can build sc and scaddins
> without the sc/addin directory, then I'm in favor of removing it. Looks
> like no one has touched this since 2000, so it's probably obsolete.
>
> So, please check if it's buildable, and go for removing it if the answer
> is yes.
My impression is that these functions are mostly sample code, probably from an
early implementation.
Some comments in .src files seem to confirm this (please see below):
/* #i54546# The code belonging to this resource file is sample code for the
* legacy AddIn interface. The interface is still supported, but deprecated.
* The strings here were displayed in the function wizard.
This patch only removes the functions, but not the support mechanism for this
type of addins.
I wanted to be sure that removing the addin mechanism itself is the right thing
to do before going ahead (it's a bit intricate).
The comment above says that it's "supported, but deprecated", so I wanted to
make sure that it can be removed now.
Thanks & regards,
Alfonso
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-legacy-Addin-functions-from-calc.patch
Type: text/x-patch
Size: 65103 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110214/2d7cef4a/attachment-0001.bin>
More information about the LibreOffice
mailing list