[Libreoffice] [PATCH] DECLARE_LIST(TOXControlList, Control*) to std::vector<Control*> in sw.

David Tardon dtardon at redhat.com
Mon Feb 14 01:47:11 PST 2011

On Sun, Feb 13, 2011 at 11:40:17PM +0000, Rafael Dominguez wrote:
> Well the patch is related to sw, tab entries in Insert->Indexes and Tables
> -> Indexes and Tables.

Looks good on a glance, but lifetime of the ptrs seem to be bound to
that of the container, so I suggest using boost::ptr_vector instead of
plain std::vector. That would mean that manual deletion of removed items
is no longer necessary.


More information about the LibreOffice mailing list