[Libreoffice] [PUSHED] Re: [PATCH] DECLARE_LIST(TOXControlList, Control*) to std::vector<Control*> in sw.

Jan Holesovsky kendy at suse.cz
Thu Feb 17 14:36:27 PST 2011

Hi Rafael,

Rafael Dominguez píše v Ne 13. 02. 2011 v 23:40 +0000:

> Well the patch is related to sw, tab entries in Insert->Indexes and
> Tables -> Indexes and Tables. 

Wow - if I am not mistaken, this is your first LibreOffice patch, and
already quite a lot of work, thank you for that! :-)  I updated few
pieces in your patch, and pushed that to master:


If you can test with the updated version, that would be great.

Can you please confirm that your contribution is LGPLv3+/MPL?

The main thing that I changed was that in some cases you used
vector<...>::iterator it = another_iterator + 1;  This is not correct,
operator+() is not defined on std::vector, so the result might be not
what you'd expect; similarly with -1.  I have changed those to ++it, or
--it (on a temporary copy, or so).

Other than that - very nice cleanup, looking forward to more! :-)

All the best,

More information about the LibreOffice mailing list