[Libreoffice] [PUSHED] Re: Re: [PATCH] Reworking build.pl: What to do with the "--html" and "--interactive" parameters

[Jan Holesovsky]

Hi Christian,

Christian Lohmaier píše v Út 15. 02. 2011 v 16:01 +0100:

> > BTW - calling 'cat' is a curious thing, can we change that to something
> > more Perl? ;-)
> 
> Well, not sure whether it is really preferable, but instead of
> system("cat $log_file");
> 
> a perl-only way would be
> 
> open(LOGFILE, "< $log_file");
> print while(<LOGFILE>);
> close(LOGFILE);

Thank you, pushed this :-)  Avoiding unnecessary forking is always good,
I'd say.

Regards,
Kendy