[Libreoffice] Splitting up source/header files for clarity

Soeren Moeller soerenmoeller2001 at gmail.com
Sun Jan 9 12:01:08 PST 2011


Hi

I have been working with sc/inc/funcdesc.hxx, and this header defines
four closely related classes, but all the implementation of these
classes is in sc/source/core/data/global.cxx together with the
implementation of a number of other classes. This makes it confusing
to find the implementations and check these classes separately, so it
would be nice to have these implementations in their own file/files.
This is even suggested by a comment in sc/inc/funcdesc.hxx which
sounds, as if the header earlier was part of some huge file too.
Moving these implementations to own files raises some questions:
- Is it best to make one file for each class, or keep them together
and make one funcdesc.cxx (containing four classes)?
- Should the license header for the new file(s) be a copy of the
license header from global.cxx (as the code is copied out), or the new
Libo header?
- Is it enough to add the new file(s) to
sc/source/core/data/makefile.mk for building, or have they to be added
somewhere else too?

Any comments are appreciated

Best Regards
Sören Möller


More information about the LibreOffice mailing list