[Libreoffice] Patch review

Kohei Yoshida kyoshida at novell.com
Thu Jan 13 08:38:46 PST 2011

Hi there,

The attached patches revert the recent two commits which consist of the
merging of OOo330-m19 changes.

It fixed i#115906 and i#116164, but the fix for i#116164 unfortunately
was pretty large and invasive, plus it introduced a regression as
reported in i#116439 of OOo bug tracker.

It is my opinion that, since these fixes don't fit *our* blocker
criteria, plus the change is too large to be in RC, reverting them will
be our best option.

The master branch already contains these fixes, and we'll work on fixing
any remaining issues in that branch.

Anyway, review and sign-off appreciated.

The 0001 is a pure git revert commit, whereas the 0002 is an application
of a patch I generated between the pre- and post-merge commit.  Git has
a special handling of reverting merge commits, so I decided to do the
revert this way.



Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida at novell.com>

More information about the LibreOffice mailing list