[Libreoffice] [PATCH] making binfilter aka StarOffice FileFormat read-only

Pierre-André Jacquod pjacquod at alumni.ethz.ch
Fri Jan 14 14:28:12 PST 2011


Hi
> 	So - if we drop that; where are we at ? :-) If we can load the file,
> edit it, and hit 'save as' (without having to click the "get me out of !
> #$#$%#%ing read-only-mode" button) 
Was pretty easy. As you asked, here patch (0001) for making the
StarWriter file format input only

> write specific ripping junk out of the binfilter code :-)
Then, as first step, I had to change in binfilter migrate, so that for
filter without EXPORT flag, the write storage is not called any more.
(see patch 0002).

Then, the following patches (0003 - 0008) are for ripping out the code
in binfilter/bf_sw. (this is not finished...)  I do it class by class,
since there are sometimes dependencies, and I like leaving between 2
commits a usable state of the stack. Further, this is easier for me to
test that I did not break anyhing - hope so at least.

Maybe I am too cautious, but I got by me twice a state where I couldn't
read anymore a StarWriter 5.0 file. So  I prefer this approach.

If you give me a Ok, I will push it to master and continue based on this
approch: filter by filter  (and class by class) ripping out, and then
the "generic" binfilter module.

Best regards
Pierre-André

ps1: in docnode/sw_nodes.cxx I took out a part that seems really for
debug... "c:\ " pathes with linux...

ps2: actually, some functions are / were defined & called within
binfilter (no call-catcher), but could not be reached any more starting
from the gui-save as trigger. So I wonder if this is a result of the
kind of uno-magical-binding (which I really dislike and not really
understand, or the other way around), or if I missed something.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Star-Writer-file-format-not-EXPORT-anymore.patch
Type: application/mbox
Size: 15031 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110114/cade8938/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-not-using-Write-function-on-loading-anymore-for-binf.patch
Type: application/mbox
Size: 1969 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110114/cade8938/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-deletion-of-StgWriter-Write-and-its-dependancies.patch
Type: application/mbox
Size: 54025 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110114/cade8938/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-deletion-of-Sw3Io-Save-and-Sw3Io-SaveAs-in-binfilter.patch
Type: application/mbox
Size: 18732 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110114/cade8938/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-class-Sw3Writer-in-binfilter-deleted.patch
Type: application/mbox
Size: 8189 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110114/cade8938/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-delete-binfilter-bf_sw-SwXMLWriter-class.patch
Type: application/mbox
Size: 26503 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110114/cade8938/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-delete-in-binfilter-bf_sw-class-StgWriter.patch
Type: application/mbox
Size: 1373 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110114/cade8938/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-delete-in-binfilter-bf_sw-class-SwWriter.patch
Type: application/mbox
Size: 3866 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110114/cade8938/attachment-0015.bin>


More information about the LibreOffice mailing list