[Libreoffice] [PATCH] [PUSHED] Cppcheck cleaning on oox

[David Tardon]

On Sun, Jan 16, 2011 at 10:00:47PM +0100, Julien Nabet wrote:
> Hello,
> 
> Here is a patch for some cppcheck cleaning on oox
Pushed, thanks!

> 
> In the file :
> oox/source/drawingml/chart/objectformatter.cxx
> in the line 930, there is this function
> void EffectFormatter::convertFormatting( PropertySet& /*rPropSet*/,
> const ModelRef< Shape >& /*rxShapeProp*/, sal_Int32 /*nSeriesIdx*/ )
> const
> {
> }
> the declaration of this function is line 662 :
>     /** Converts effect formatting to the passed property set. */
>     void                convertFormatting(
>                             PropertySet& rPropSet,
>                             const ModelRef< Shape >& rxShapeProp,
>                             sal_Int32 nSeriesIdx ) const;
> 
> Does this function do something or should it be implemented (or just
> simply remove it) ?
> 

It is called at several places, so it looks like it should be
implemented. I removed the added const from it, as it might cause
confusion.

D.