[Libreoffice] [PATCH] possible null-dereferencing found by cppcheck

Caolán McNamara caolanm at redhat.com
Tue Jan 18 06:55:06 PST 2011

On Tue, 2011-01-18 at 07:45 -0700, Tor Lillqvist wrote:
> >> Or am I missing something... 
> > Yes, we have a miserable trap of fall-through:
> No, I did see the fall-through. But if pDlg is NULL (a bit earlier), we
>  don't enter the block that contains the switch with the fall-through,
>  where the other (hopefully only other possible) case does set pArgs

Those abstract dialogs should never fail in practice, nevertheless I've
added an early return for that case.


More information about the LibreOffice mailing list