[Libreoffice] [PATCH] possible null-dereferencing found by cppcheck

Takeshi Abe tabe at fixedpoint.jp
Tue Jan 18 07:00:03 PST 2011


On Tue, 18 Jan 2011 07:45:04 -0700, "Tor Lillqvist" <tlillqvist at novell.com> wrote:
>>> Or am I missing something... 
>> Yes, we have a miserable trap of fall-through:
> 
> No, I did see the fall-through. But if pDlg is NULL (a bit earlier), we don't enter the block that contains the switch with the fall-through, where the other (hopefully only other possible) case does set pArgs.
You are right. I now understood your point. Sorry for that noise.

Cheers,
-- Takeshi Abe


More information about the LibreOffice mailing list