[Libreoffice] [PATCH] removed some bogus comments

Cedric Bosdonnat cedric.bosdonnat.ooo at free.fr
Thu Jan 27 00:47:59 PST 2011

Hello Suguru,

First, many thanks for your patch!

On Thu, 2011-01-27 at 01:43 +0900, suguru hirahara wrote:
> I made a patch file. Please notice me if there's any mistake.

Well, you removed entirely some comments containing references to some
public bug reports (they look like #i12345#). In this case we want to
keep them to keep a history.

For example in comments like
// --> OD 2005-12-12 #i27301# - use new type definition for <_nStates>

you keep:
// #i27301# - use new type definition for <_nStates>

Could you please amend your patches to take this comment into account?

Cédric Bosdonnat
LibreOffice hacker
OOo Eclipse Integration developer

More information about the LibreOffice mailing list