[Libreoffice] [PUSHED] cpp cleanliness: fixed some memleaks binfilter

Kenneth Venken kenneth.venken at gmail.com
Sat Jan 29 14:35:33 PST 2011


2011/1/28 Michael Meeks <michael.meeks at novell.com>

> Hi there,
>
> On Thu, 2011-01-27 at 20:55 +0100, Kenneth Venken wrote:
> > these patches remove some comments
> > from ./filters/binfilter/bf_svx/source/editeng/svx_editobj.cxx and
>
>         I've pushed these two.
>
> >  fixes two memleaks.
>
>        But this third one looks more problematic to me (at least on the
> surface) :-)
>
>        We allocate pC and then store its pointer in aContents (cf.
> CreateAndInsertContent) - right ? surely they are freed by
> DeleteContents called from the destructor ?
>
your right. I guess this is a cppcheck false positive.

>
>        Thanks though,
>
>                Michael.
>
> --
>  michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110129/46f68734/attachment.html>


More information about the LibreOffice mailing list