[Libreoffice] [PUSHED] cpp cleanliness: fixed some memleaks binfilter
someone at boldandbusted.com
Sun Jan 30 10:47:23 PST 2011
On 01/29/11 14:35, Kenneth Venken wrote:
> 2011/1/28 Michael Meeks <michael.meeks at novell.com>
>> Hi there,
>> On Thu, 2011-01-27 at 20:55 +0100, Kenneth Venken wrote:
>>> these patches remove some comments
>>> from ./filters/binfilter/bf_svx/source/editeng/svx_editobj.cxx and
>> I've pushed these two.
>>> fixes two memleaks.
>> But this third one looks more problematic to me (at least on the
>> surface) :-)
>> We allocate pC and then store its pointer in aContents (cf.
>> CreateAndInsertContent) - right ? surely they are freed by
>> DeleteContents called from the destructor ?
> your right. I guess this is a cppcheck false positive.
>> Thanks though,
>> michael.meeks at novell.com <><, Pseudo Engineer, itinerant idiot
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
Please report this false positive to cppcheck's upstream bug db, so it
will be fixed for them and for us. :)
Senior Linux Systems Administrator,
ilikelinux Consulting (http://www.ilikelinux.com/)
Bold and Busted LLC (http://www.boldandbusted.com/)
More information about the LibreOffice