[Libreoffice] [PATCH] refactoring gendict

Mon Jan 31 04:04:37 PST 2011

2011/1/31 Michael Meeks <michael.meeks at novell.com>

>
> On Sun, 2011-01-30 at 14:35 +0100, Kenneth Venken wrote:
> > So, should i make the changes to the code or have you already done
> > them?
>
>         Judging by the git log (they're not pushed), I'd say that Norbert
> wanted you to re-submit a patch with his suggestions :-)
>
> I think i've implemented all the suggestions. There's one hard coded limit
(i < 0x1FFF) i don't get. Why isn't it 0x2000 since existMark has a size of
0x10000. I changed it to i < 0x2000. This will not have an influence on
xdictionary since the 0x1FFF limit is hardcoded there too. I'll look into
xdictionary next to see if i can fix the fixme in gendict. Maybe then this
will make sence to me too.

I've also added support to print to standard output, but i don't know how to
fix the build so it will pipe the output to the file.

>        Looks like some nice cleanups though,
>
>        Thanks !
>
>                Michael.
>
> --
>  michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110131/d9107514/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-added-some-documentation-to-gendict.patch
Type: text/x-patch
Size: 1533 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110131/d9107514/attachment-0018.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-refactored-out-some-simple-print-functions.patch
Type: text/x-patch
Size: 2997 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110131/d9107514/attachment-0019.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-refactored-out-dataArea.patch
Type: text/x-patch
Size: 5205 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110131/d9107514/attachment-0020.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-refactored-out-all-array-functions.patch
Type: text/x-patch
Size: 8623 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110131/d9107514/attachment-0021.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-reduced-scope-of-some-variables.patch
Type: text/x-patch
Size: 5207 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110131/d9107514/attachment-0022.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-readability-changes.patch
Type: text/x-patch
Size: 7924 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110131/d9107514/attachment-0023.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-changed-some-loop-constructs.patch
Type: text/x-patch
Size: 1796 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110131/d9107514/attachment-0024.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-more-comments.patch
Type: text/x-patch
Size: 4806 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110131/d9107514/attachment-0025.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-some-changes.patch
Type: text/x-patch
Size: 1186 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110131/d9107514/attachment-0026.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-made-private-functions-static-reordered-main.patch
Type: text/x-patch
Size: 7631 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110131/d9107514/attachment-0027.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-exists-and-charArray-declared-static.patch
Type: text/x-patch
Size: 7074 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110131/d9107514/attachment-0028.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0012-removed-use-of-count-and-casting.patch
Type: text/x-patch
Size: 5721 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110131/d9107514/attachment-0029.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0013-some-small-changes.patch
Type: text/x-patch
Size: 1491 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110131/d9107514/attachment-0030.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0014-use-of-fputs.patch
Type: text/x-patch
Size: 5868 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110131/d9107514/attachment-0031.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0015-printing-to-stderr.patch
Type: text/x-patch
Size: 1283 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110131/d9107514/attachment-0032.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0016-added-support-to-write-to-stdout.patch
Type: text/x-patch
Size: 1552 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110131/d9107514/attachment-0033.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0017-OSL_ENSURE.patch
Type: text/x-patch
Size: 1215 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110131/d9107514/attachment-0034.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0018-replaced-count-with.patch
Type: text/x-patch
Size: 2696 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110131/d9107514/attachment-0035.bin>