[Libreoffice] [REVIEW] fix for ppt export fdo#32709 (and possibly more issues)

[Radek Doulík]

Hi all,

I am looking for 1 review to include the patch in 3-4 branch. It fixes
ppt export and possibly more areas where the code use SvGlobalName class
and < operator.

It is regression in "#i101100# strict-alias clean" changes.

The original code (before strict alias clean) was using beginning of
pImp->szData in comparison

-    else if( *(USHORT *)&pImp->szData[ 4 ] == *(USHORT *)&rObj.pImp->szData[ 4 ] )
-        return *(UINT32 *)pImp->szData < *(UINT32 *)rObj.pImp->szData;

The fix is here

http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=345dc7961bc142f167a1b8e5f43f4439e8234f06

commit 345dc7961bc142f167a1b8e5f43f4439e8234f06
Author: Radek Doulik <rodo at novell.com>
Date:   Mon Jul 11 20:36:47 2011 +0200

    fix regression in SvGlobalName::operator <
    
     - it was comparing wrong parts and ommiting part of ID's, resulting
       in wrong results and thus ::std::map didn't work well with default
       less compare function of it's keys
     - fixes fdo#32709

Cheers
Radek