[Libreoffice] [REVIEW] 4 minutes 27 seconds -> 11 seconds

[Caolán McNamara]

On Tue, 2011-07-12 at 12:51 +0200, Radek Doulik wrote:
> Hi Caolán,
> 
> the patch looks good to me.
> 
> I am also surprised by the speedup (given that it always inserts at the
> end of the vector array in your case). Hard to check without the actual
> document. Might be problem in std::vector not detecting that the rest of
> reserved space doesn't need to be moved or something?

Yeah, that's sort of what it looks like, though for me the whole
callstack ends up setting up camp in some -DFORTIFY->selinux chain of
goo.

> You might try to load the document into valgrinded libreoffice just to
> be sure that it doesn't mess memory.

Yeah, my test-case is good under valgrind FWIW.

C.