[Libreoffice] [PUSHED] Allow GoUpSel, GoDownSel, GoLeftsel, GoRightSel to use "By" property

[Eike Rathke]

Hi Caolán,

On Friday, 2011-07-29 12:26:04 +0100, Caolán McNamara wrote:

> > I left
> > SID_CURSORBLKDOWN_SEL
> > SID_CURSORBLKUP_SEL
> > SID_CURSORBLKLEFT_SEL
> > SID_CURSORBLKRIGHT_SEL
> > 
> > untouched because repetitions makes no sense to them AFAIK
> 
> I see that the pre-existing ::ExecuteCursor doesn't make a distinction
> for the Block selections, it just repeats them the same as non block. So
> I adjusted your patch to include them as well to be consistent between
> moving, and selecting. (hopefully I haven't cocked this up, Kohei, et.
> al. can double check it for me I guess)

Should be fine. At least the called methods seem to evaluate the
arguments properly. Whether the user expected the resulting action might
be different, as it depends on the starting position (within a data
block or outside) and odd vs even repeat values.

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110729/7108a4f0/attachment.pgp>