[Libreoffice] [patch] remove duplicate placeholder icons

[Joachim Trémouroux]

Hi everybody,

I have made some stats to check the number of duplicate icons in the
clone/artwork directory:

$ find . -name "*.png" -exec md5sum {} \; > /tmp/icon_list.txt

$ wc -l /tmp/icon_list.txt
23916 /tmp/icon_list.txt

$ cat /tmp/icon_list.txt | cut -d " " -f 1 | sort | uniq -c | wc -l
15063

Only 15063 unique icons out of a total of 23916...


$ cat /tmp/icon_list.txt | cut -d " " -f 1 | sort | uniq -c | sort -nr
    139 807dae78a1ec98d3ea5b3e32c98ffe90
     96 80d815d13cda9b63ebd372fec588cfd5
     51 b39f5c7219187dad35226d3643ac2d3f
     51 4bd00715b1e5beb713c04f887e9835ef
...

Let's start with the most duplicated one
$ grep 807dae78a1ec98d3ea5b3e32c98ffe90 /tmp/icon_list.txt | sort
807dae78a1ec98d3ea5b3e32c98ffe90  ./default_images/fpicker/res/list.png
807dae78a1ec98d3ea5b3e32c98ffe90  ./default_images/res/missing_icon.png
807dae78a1ec98d3ea5b3e32c98ffe90  ./default_images/sfx2/res/command.png
807dae78a1ec98d3ea5b3e32c98ffe90  ./default_images/sfx2/res/dictate.png
...
807dae78a1ec98d3ea5b3e32c98ffe90  ./ooo_custom_images/oxygen/res/sx03124.png
807dae78a1ec98d3ea5b3e32c98ffe90  ./ooo_custom_images/oxygen/res/sx03134.png
...

These are icons that can be replaced by the default fallback icon. The
attached patch #1 delete all these icons.


The second most duplicated :
$ grep 80d815d13cda9b63ebd372fec588cfd5 /tmp/icon_list.txt  | sort
80d815d13cda9b63ebd372fec588cfd5  ./default_images/sfx2/res/ln0100.png
80d815d13cda9b63ebd372fec588cfd5  ./default_images/sfx2/res/ln0102.png
80d815d13cda9b63ebd372fec588cfd5  ./default_images/sfx2/res/ln0104.png
80d815d13cda9b63ebd372fec588cfd5  ./default_images/sfx2/res/ln0106.png

All these ones can also be replaced by the fallback icon. patch #2 deletes
all these icons.


Next one ...
$ grep b39f5c7219187dad35226d3643ac2d3f /tmp/icon_list.txt | sort
b39f5c7219187dad35226d3643ac2d3f
./ooo_custom_images/crystal/cmd/ar/lc_underlinedouble.png
...
b39f5c7219187dad35226d3643ac2d3f
./ooo_custom_images/crystal/cmd/ko/lc_underlinedouble.png
b39f5c7219187dad35226d3643ac2d3f
./ooo_custom_images/crystal/cmd/lc_underlinedouble.png
b39f5c7219187dad35226d3643ac2d3f
./ooo_custom_images/crystal/cmd/nl/lc_underlinedouble.png
...
b39f5c7219187dad35226d3643ac2d3f
./ooo_custom_images/crystal/cmd/tr/lc_underlinedouble.png
b39f5c7219187dad35226d3643ac2d3f
./ooo_custom_images/oxygen/cmd/cs/lc_underlinedouble.png
...
b39f5c7219187dad35226d3643ac2d3f
./ooo_custom_images/oxygen/cmd/km/lc_underlinedouble.png

The locale directories redefine the main icon defined in
./ooo_custom_images/crystal/cmd and ./ooo_custom_images/oxygen/cmd
The attached patch #3 takes care of these unnecessary icons.

If this patch is OK, I will continue with all the other duplicated icons.
I think it will allow a massive cleanup in the different locale directories.


Can you please review these patches?

Regards,
Joachim.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110607/0a45ce9a/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Removed-some-placeholder-icons.patch
Type: text/x-patch
Size: 90610 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110607/0a45ce9a/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Remove-some-placeholder-icons.patch
Type: text/x-patch
Size: 76272 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110607/0a45ce9a/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Remove-duplicate-icons-for-crystal-and-oxygen-themes.patch
Type: text/x-patch
Size: 78236 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110607/0a45ce9a/attachment-0005.bin>