[Libreoffice] [REVIEW] Fix for fdo#37622

Kohei Yoshida kyoshida at novell.com
Thu Jun 9 22:17:40 PDT 2011

Ok.  This is the last one for today.

Here is the bug


and here is the commit I'd like to cherry-pick to the -3-4 branch


The old code incorrectly returned NULL when the last font ID was passed,
because of the wrong boundary check.

In XLS, font IDs are zero-based when it's less than 4, but it becomes
one based when greater than 4 according to the spec.  This lookup
behavior was accidentally altered during ScfDefList removal.

Review & sign-off appreciated.


Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida at novell.com>

More information about the LibreOffice mailing list