[Libreoffice] [REVIEW] [PUSHED] Fix for fdo#37622

Katarina Machalkova kmachalkova at suse.cz
Fri Jun 10 03:04:06 PDT 2011

> Ok.  This is the last one for today.
> Here is the bug
> https://bugs.freedesktop.org/show_bug.cgi?id=37622
> and here is the commit I'd like to cherry-pick to the -3-4 branch
> http://cgit.freedesktop.org/libreoffice/calc/commit/?id=099fd0fd91485797362
> 259e45b1a971dda0511a3
> The old code incorrectly returned NULL when the last font ID was passed,
> because of the wrong boundary check.
> In XLS, font IDs are zero-based when it's less than 4, but it becomes
> one based when greater than 4 according to the spec.  This lookup
> behavior was accidentally altered during ScfDefList removal.

Reviewed, cherry-picked & pushed.
Thanks for fixing this, I was pretty close to finding the root cause of the 
last font in the list not being applied, but not quite there yet.

  \\\\\              Katarina Machalkova    
  \\\\\\\__o          LibO developer
__\\\\\\\'/_          & hedgehog painter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110610/bab23d21/attachment.pgp>

More information about the LibreOffice mailing list