[Libreoffice] [PATCH] Fix for Bug 37484 - On any animation change, current position in list is lost

Luke Symes allsymes at gmail.com
Wed Jun 22 01:11:39 PDT 2011


Hi,

Please find attached my patches to fix Bug 37484 [1]. It would be great if
someone could review them.

I ended up implementing my own method for scrolling to a listbox entry, and
also making public the methods related to absolute position of entries in
the list. I hope this was an OK thing to do? I tried hard to make the code
that saves & restores list position compact and readable; please tell me if
it makes sense. I have built and tested my changes a lot, but only on linux.

Kind regards,

Luke.

[1] https://bugs.freedesktop.org/show_bug.cgi?id=37484
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110622/f53a1dc3/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Set-the-listbox-height-to-an-integer-multip.libs-gui.patch
Type: text/x-patch
Size: 1277 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110622/f53a1dc3/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Implement-ScrollToAbsPos-for-listboxes.libs-gui.patch
Type: text/x-patch
Size: 4061 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110622/f53a1dc3/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Implement-GetLastEntryInView-for-SvTreeList.libs-gui.patch
Type: text/x-patch
Size: 2005 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110622/f53a1dc3/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Restore-the-scroll-position-of-the-CustomAni.impress.patch
Type: text/x-patch
Size: 5135 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110622/f53a1dc3/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Don-t-update-CustomAnimationList-when-we-are.impress.patch
Type: text/x-patch
Size: 1015 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110622/f53a1dc3/attachment-0004.bin>


More information about the LibreOffice mailing list