[Libreoffice] [PUSHED] fdo#31251 - Improve default page layout

Michael Meeks michael.meeks at novell.com
Thu Mar 3 03:59:19 PST 2011

Hi Sebastien,

On Tue, 2011-03-01 at 23:42 +0100, Sébastien Le Ray wrote:
> Here is a complete patch for fdo#31251. It adds a smooth shadow to the
> page.

	Wow - it is really pretty indeed :-) I just pushed it. Nice work ! can
you confirm is it LGPLv3+/MPL ?

	Incidentally, it would be lovely to have the post-it notes, not only to
have a border, but to have curved corners at the bottom, but not the
top, so they really look like sticky notes. ie. take a sticky note an
stick it flat on your desk, and you see the effect [ both bottom corners
curl slightly ] ;-) possibly that will require some (manual?)
re-coloring action of the bitmaps, which might be slightly painful,
though I guess it is just a matter of keeping a constant AlphaMask
bitmap around, and merging it into a BitmapEx with a Bitmap (of the same
size obviously) 'Erase'd with the correct color for the note.

> During its development, I found that SwRect::_Intersection (used in
> page margin painting) returns negative height/width if the two
> rectangles do not overlap. I don't know if it is the expected behavior
> or a bug. If it's a bug I guess I can provide a patch.

	Ho hum - probably a difficult one to audit for, to check every location
to ensure they are not depending on this. Possibly it makes the impl.
faster too (?).

	Well worth documenting though in the API.

	Thanks !


 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list