[Libreoffice] [PATCH] [PUSHED] Fix and enable more unit tests in sal/qa/rtl

David Tardon dtardon at redhat.com
Fri Mar 18 02:48:14 PDT 2011

On Thu, Mar 17, 2011 at 02:50:54PM +0100, Theo van Klaveren wrote:
> Hello again,
> More unit test hacking. Only the ones that work are enabled.

Pushed, thanks!

> Some questions that are coming up:
>  - Some unit tests contain .xsce files that seem to be used to tell told the
> old unit testing framework that the test is expected to segfault. This does
> not seem to work with cppunittester?

No, it doesn't.

>  - The math test fails in a way that is unexpected. The test checks that
> double -> string -> double conversion works, and expects 1.#INF to result in
> 1.#INF. The API docs agree, but the result is INF.

This was probably broken by commit
9111657228393eb0cf0db493202abda300754f68 . I am inclined to accept the
new behaviour and fix the docs and test (it seems to be a real corner
case anyway), but maybe others have another opinion?


More information about the LibreOffice mailing list