[Libreoffice] [PUSHED] Re: [PATCH] Fix and enable more unit tests in sal/qa/rtl

Caolán McNamara caolanm at redhat.com
Fri Mar 18 02:53:39 PDT 2011

On Thu, 2011-03-17 at 14:50 +0100, Theo van Klaveren wrote:
> Hello again,
> More unit test hacking. Only the ones that work are enabled.

Looks good, pushed, thanks for these.

> Some questions that are coming up:
>  - Some unit tests contain .xsce files that seem to be used to tell
> told the old unit testing framework that the test is expected to
> segfault. This does not seem to work with cppunittester?

Sounds sort of dubious to have tests that expect to segfault :-),
crashes that are supposed to crash would be probably tricky to get cross
platform friendly. I'm unconvinced that the .xsce files are useful to

>  - The math test fails in a way that is unexpected. The test checks
> that double -> string -> double conversion works, and expects 1.#INF
> to result in 1.#INF. The API docs agree, but the result is INF.

Might have to poke back through the implementation of this and see what
changes might have happened since the test was written to see if the
code changed for a good reason or a bad one to see if its now a bug into
impl+docs or a bug in the test.


More information about the LibreOffice mailing list