[Libreoffice] Empty functions in chart module
Michael Meeks
michael.meeks at novell.com
Fri May 6 02:10:32 PDT 2011
Hi Julien,
On Thu, 2011-05-05 at 23:39 +0200, Julien Nabet wrote:
> By digging into cppcheck logs, I saw this :
> [chart2/source/model/template/BubbleChartType.cxx:69] Technically the
> member function
> 'StaticBubbleChartTypeDefaults_Initializer::lcl_AddDefaultsToMap' can be
> const
> [chart2/source/model/template/BubbleChartTypeTemplate.cxx:76]:
> Technically the member function
> 'StaticBubbleChartTypeTemplateDefaults_Initializer::lcl_AddDefaultsToMap' can
> be const
>
> But these functions are empty.
> So :
> - should they be removed ?
They certainly could be - I guess if people are implementing them, they
will most likely look at other modules in chart2/ to see the pattern
that is used here.
HTH,
Michael.
--
michael.meeks at novell.com <><, Pseudo Engineer, itinerant idiot
More information about the LibreOffice
mailing list