[Libreoffice] Empty functions in chart module
serval2412 at yahoo.fr
Sat May 7 02:35:45 PDT 2011
Le 06/05/2011 11:10, Michael Meeks a écrit :
> Hi Julien,
> On Thu, 2011-05-05 at 23:39 +0200, Julien Nabet wrote:
>> By digging into cppcheck logs, I saw this :
>> [chart2/source/model/template/BubbleChartType.cxx:69] Technically the
>> member function
>> 'StaticBubbleChartTypeDefaults_Initializer::lcl_AddDefaultsToMap' can be
>> Technically the member function
>> 'StaticBubbleChartTypeTemplateDefaults_Initializer::lcl_AddDefaultsToMap' can
>> be const
>> But these functions are empty.
>> So :
>> - should they be removed ?
> They certainly could be - I guess if people are implementing them, they
> will most likely look at other modules in chart2/ to see the pattern
> that is used here.
The 2 methods have been removed, the patch was pushed on Master.
Generally speaking, if other methods like these are found, should they
be removed too or each case should be analyzed specifically ?
More information about the LibreOffice