[Libreoffice] Duplicate code: replace mbBreak with hasLineBreak?

Chr. Rossmanith ChrRossmanith at gmx.de
Mon May 16 00:37:10 PDT 2011


Hi,

I had a closer look at output2.cxx.

(1) ScOutputData::DrawEditTopBottom tests "if (rParam.hasLineBreak())"
(2) ScOutputData::DrawEditBottomTop tests "if (rParam.mbBreak)"

with

bool ScOutputData::DrawEditParam::hasLineBreak() const
{
     return (mbBreak || (meOrient == SVX_ORIENTATION_STACKED) || 
mbAsianVertical);
}

so (2) is more restrictive than (1). Would it be valid to have 
rParam.hasLineBreak() in (2) as well?

Thank you,
Christina



More information about the LibreOffice mailing list