[Libreoffice] [PATCH] Simplified #define OSL_FILE_TRACE
Michael Meeks
michael.meeks at novell.com
Mon May 16 07:54:37 PDT 2011
Hi Christina,
On Fri, 2011-05-13 at 21:40 +0200, Chr. Rossmanith wrote:
> if I remember correctly cppcheck complained about some statements in the
> context of OSL_FILE_TRACE. This patch simplifies the definition of
> OSL_FILE_TRACE ( => code better readable) and facilitates compiling
> without warnings.
:-) I imagine the original is down to compilers not having sane var-arg
macro support.
Whether we can rely on that working everywhere nowadays is an
interesting question ;-) I guess a Mac / Windows opinion is worth
getting. If we can - then osl/diagnose.h should be fixed up too.
ATB,
Michael.
--
michael.meeks at novell.com <><, Pseudo Engineer, itinerant idiot
More information about the LibreOffice
mailing list