[Libreoffice] HTML_ColorEntry sal_uLong->sal_uInt32

Michael Meeks michael.meeks at novell.com
Tue May 17 03:20:41 PDT 2011

Hi Christina,

On Tue, 2011-05-17 at 09:29 +0200, Chr. Rossmanith wrote:
> Am 16.05.2011 17:05, schrieb Michael Meeks:
> > On Fri, 2011-05-06 at 21:53 +0200, Chr. Rossmanith wrote:
> >> I think the variable nColor from struct HTML_ColorEntry in htmlkywd.cxx
> >> can be changed from sal_uLong to sal_uInt32. Continue to change return
> Of course. Find it attached.

	It looks nice :-) then again - I noticed this mess:

#if defined( WNT )
#if defined( ICC )

	Which (you would hope) would be implied by the extern "C" { } construct
on Windows - with a SAL_CALL macro annotation instead :-) That won't
work for ICC - but - our ICC support is almost certainly broken anyway
and I doubt anyone cares.

	It seems there are a load of other #if defined WNT - conditionals
around __cdecl in similar circumstances that'd be great to fix if you
have the energy :-)

	Thanks !


 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list