[Libreoffice] Variable 'bFreePixmap' is not assigned a value in vcl/unx/source/gdi/salbmp.cxx

Michael Meeks michael.meeks at novell.com
Thu May 19 03:42:29 PDT 2011


On Sun, 2011-05-08 at 15:09 +0200, Julien Nabet wrote:
> I found this with cppcheck :
> [vcl/unx/source/gdi/salbmp.cxx:795]: (style) Variable 'bFreePixmap' is 
> not assigned a value

	Ho hum - I beg to differ:

        bool bFreePixmap = false;
        if( bSuccess && (args[0] >>= bFreePixmap) && bFreePixmap )

	Surely we assign it a value with the >>= operator ? true - it is not a
particularly pleasant use of the operator - but hey - UNO is like that
(sexy huh?). Why have:

	any.isBoolean() && any.asBoolean()

	or something - when we can have some mind-mashed operator, and a
confusing temporary ;-)

	Or did I miss something ? presumably another cppcheck false-positive
that needs filing & fixing (?).

	Thanks,

		Michael.

-- 
 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot




More information about the LibreOffice mailing list