[Libreoffice] [Review] Patch for fdo#37429: crash when copy/paste table from writer to calc

Cedric Bosdonnat cedric.bosdonnat.ooo at free.fr
Mon May 23 05:04:20 PDT 2011


On Mon, 2011-05-23 at 04:21 -0600, Tor Lillqvist wrote:
> >>> On 2011-05-23 at 00:50, <markus.mohrhard at googlemail.com> wrote:
> > The problem here is that you are not allowed to access any element as long
> > as the ptr_vector is empty.
> 
> > I think we should include this patch in 3-4-0.
> 
> Another crash introduced by a "Remove DECLARE_LIST" change, I am so not surprised.
> 
> +1 from me. Push this one-line patch first to master separately so that it can be cherry-picked, then do the more intrusive master-only rework. Thanks.

That one looks safe to me.

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr



More information about the LibreOffice mailing list