[Libreoffice] [Review] Patch for fdo#37429: crash when copy/paste table from writer to calc

Kohei Yoshida kyoshida at novell.com
Mon May 23 09:39:31 PDT 2011


On Sun, 2011-05-22 at 23:50 +0200, Markus Mohrhard wrote:

> But all in all in my opinion we should rework the whole pDefaultList
> part in master. I think it is bad style to create a boost::ptr_vector
> with new as long as it is not necessary, so if you agree I would
> rewrite these few lines for master.

Agreed.  I'd rather the default list be a concrete data member rather
than a pointer, since it's new'ed during the construction of
ScRTFParser.

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida at novell.com>



More information about the LibreOffice mailing list