[Libreoffice] [PATCH] __cdecl -> SAL_CALL (libs-gui)

Michael Meeks michael.meeks at novell.com
Mon May 23 08:38:45 PDT 2011

Hi Christina,

On Mon, 2011-05-23 at 10:02 +0200, Chr. Rossmanith wrote:
> the attached patch removes __cdecl and uses SAL_CALL instead. For future 
> work: I suppose that I can omit files having win32 in their path?

	Looks like a beautiful patch to me. And yes, we shouldn't have #ifdef
WIN conditionals in files built only on windows (I hope) ;-)

> Compiles fine for me but make check never completed without errors. What 
> shall I do with these error messages? IRC or post to list and hope for 
> help or accept that they exist  :-)

	Are the errors different before / after the patch I guess is the
question :-) 'make check' passes for me - I tried to apply the patch to
checkthat, but it didn't apply to master (sorry).



 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list