[Libreoffice] [PATCH] __cdecl -> SAL_CALL (libs-gui)

Tor Lillqvist tlillqvist at novell.com
Mon May 23 09:02:03 PDT 2011

> Looks like a beautiful patch to me. And yes, we shouldn't have #ifdef
> WIN conditionals in files built only on windows (I hope) ;-)

Actually I think OOo uses WIN  to mean 16-bit Windows 3.x...(and Win9x?), at least in some contexts. It is WNT that it uses to indicate 32-bit Windows.

See for instance http://opengrok.libreoffice.org/xref/libs-core/fpicker/test/makefile.mk#83 where   .IF "$(GUI)" == "WIN"   is used around stuff that clearly is only for 16-bit Windows.

Yes, the mind boggles, such stuff still around in the codebase.

(Of course it might be possible that in some places WIN is used also for 32-bit Windows.)


More information about the LibreOffice mailing list