[Libreoffice] SolidMarkHandles - [PATCH] removed leftovers of the Simple Handles option

[Tim Hardeck]

Hi,

I have created a patch to remove the leftovers mentioned here and some
additional I have found.

Tim

On 11/08/2011 10:29 PM, Stephan Bergmann wrote:
> Hi all,
>
> Looks like
> <http://cgit.freedesktop.org/libreoffice/core/commit/?id=ec4f69493b50c15861b0cdcc290ecedd00efb51d>
> "removed Simple Handles option" removed support for SolidMarkHandles
> property from sw/source/ui/uno/unomod.cxx while it is still listed in
> offapi/com/sun/star/text/ViewSettings.idl and checked in qadevOOo
> (mentioned in
> qadevOOo/objdsc/sw/com.sun.star.comp.office.SwXViewSettings.csv,
> qadevOOo/tests/basic/ifc/text/ViewSettings/test_ViewSettings.xba, and
> qadevOOo/tests/java/ifc/text/_ViewSettings.java), and so broke
> sw_unoapi subsequenttest:
>
>> Creating: sw.SwXViewSettings
>> [...]
>> LOG> Execute: SolidMarkHandles
>> LOG> Tested XPropertySet does not contain'SolidMarkHandles' property
>> Method SolidMarkHandles finished with state FAILED
>> LOG> SolidMarkHandles: PASSED.FAILED
>> [...]
>> ***** State for
>> sw.SwXViewSettings::com::sun::star::text::ViewSettings ******
>> [sw.SwXViewSettings::com::sun::star::text::ViewSettings::SolidMarkHandles]
>> is testcode: [SolidMarkHandles] - PASSED.FAILED
>
> Given that SolidMarkHandles is listed in
> com.sun.star.text.ViewSettings, it is unclear to me whether it should
> indeed be removed?
>
> (Btw, "SolidMarkHandles" is also still mentioned in
> sw/source/core/unocore/unoprnms.cxx,
> binfilter/bf_sw/source/core/unocore/sw_unoprnms.cxx, and
> binfilter/bf_sw/source/ui/uno/sw_unomod.cxx.)
>
> Stephan
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice


-- 
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)
Maxfeldstr. 5, 90409 Nürnberg, Germany
T: +49 (0) 911 74053-0  F: +49 (0) 911 74053-483
http://www.suse.de/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-removed-leftovers-of-the-Simple-Handles-option.patch
Type: text/x-patch
Size: 25665 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111109/34f14679/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111109/34f14679/attachment-0001.pgp>