[Libreoffice] [PATCH] Fix for fdo#42178

Ivan Timofeev timofeev.i.s at gmail.com
Wed Nov 16 05:35:11 PST 2011


Hi there,

I have fixed https://bugs.freedesktop.org/show_bug.cgi?id=42178 :-) ,
but I think an additional review will not be superfluous, since I am
still a newbie.

The fact is SwDocShell::GetWrtShell() always returns 0 in page
preview. And Writer dies due to that in "lcl_GetPrintUIOptions"
function (sw/source/ui/uno/unotxdoc.cxx).

The second patch makes testing of the first one easier. :-) Because,
when you press "Cancel" in a print dialog, then make changes to a doc
and open a print dialog again, you currently will not see any effect.
Options will not be updated. The patch fixes this.

If someone will approve the patches, I will push them.

Thanks,
        Ivan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fix-fdo-42178-crash-when-printing-from-Page-Preview.patch
Type: text/x-diff
Size: 1851 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111116/8caff761/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-always-refresh-print-ui-options-not-only-after-print.patch
Type: text/x-diff
Size: 997 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111116/8caff761/attachment-0001.patch>


More information about the LibreOffice mailing list