[Libreoffice] [PATCH] translated comments in /svx/source/stbctrls
Cor Nouws
oolst at nouenoff.nl
Mon Nov 21 04:17:27 PST 2011
Hi Phillip,
Philipp Weissenbacher wrote (21-11-11 12:48)
> I took a quick look at your patch and found these minor things:
Thanks :-)
> Line 95: "Create an intance of the implementation class, enable the
> page numbering by default"
> There's a typo (intance -> instance) and in German text it says
> "Zeitanzeige" (display of time, or showing of the time), but you
> translated it as "page numbering".
> I can't check more closely right, but it seems wrong.
Yes, it is wrong. On line 139 on I used the correct translation..
(NB, I think I saw a comment somewhere, that display of date/time have
been completely disabled .. shall look if I can find that again)
> Line 147: "// the combi-controller, always set the curent Id as HelpId"
> "Because the combi controler always sets the current Id as HelpId,
> clean the cached Helptext first"
> seems a bit more appropriate to me.
Indeed.
> Line 201: "set only strings as text at the statusBar, because the Help-Tips"
> "... so that the Help-Tips works ..."
Agree too.
Note that this comment was not too clear to me.
> The rest looks fine to me. Nicely done.
Thanks - so now ask to remove the firs so that I can send an updated patch?
Cheers,
--
- Cor
- http://nl.libreoffice.org
More information about the LibreOffice
mailing list