[Libreoffice] Assertions and Logging

[Stephan Bergmann]

On 11/22/2011 11:50 PM, Miklos Vajna wrote:
> These changes cause that without an
>
> export SAL_LOG="+INFO"
>
> former OSL_TRACE() messages do not show up on the console, even with
> dbglevel=2.
>
> I like that SAL_LOG can now filter SAL_INFO messages, but are you sure
> it's a good idea to disable them all by default with dbglevel=2, instead
> of enabling them by default (when SAL_LOG is not set), like it was
> before?
>
> IOW, is the attached patch OK?

My understanding is as follows:

- There is a large number of OSL_TRACE calls all over the code base, 
producing large amounts of output at runtime.

- Nobody wants to see all that output at once.  People are generally 
only interested in the OSL_TRACE output from some specific module etc.

- For that, in the past it was necessary to recompile the relevant code 
with dbglevel=2.  Now, no recompilation is necessary any longer, you 
just need to add +INFO.area to SAL_LOG at runtime.

Your patch would imply that you either (a) routinely build the whole 
code base with dbglevel=2 (do you really do that? does the amount of 
resulting output not intimidate you?), or (b) need to recompile just sal 
with dbglevel=2 before automatically (without setting SAL_LOG) seeing 
any (but again, also all) OSL_TRACE output.

Is that really your use case?

Stephan