[Libreoffice] [PATCH] fdo#42286, do not shrink the selected area

[Pierre-André Jacquod]

hello,
here attached an new patch (hopefully wiser) to solve the mentioned bug. 
This  ensure that the call to ExtendDataArea does as commented in the 
code sc/source/core/tool/dbdata.cxx :
// Extend the DB area to include data rows immediately below.
and does not shrink the original area... So having a smaller area after 
the function is clearly wrong.

If you agree, I will push it to master.

BUT this is a workaround, to compensate the not so correct behaviour of 
GetDataArea :-(

I did this patch in order to bring the correction in time for 3.5.0 & 
3.4.5, but I agree, that this is suppressing a symptom and not the root 
cause.

About the root cause: I am still studing the code of the both mentioned 
functions and their integration with filters and filtered areas. Before 
touching it, I would like to define what should be the desired effect. 
Further some tests have shown me that the behaviour (regarding area) is 
not the same, depending if the filter is activated with 
Data->Filter->AutoFilter or Standard filter. I fear some parts will need 
to be quite overhauled.

As said, won't be ready for 3.5, so first this short term solution.

Thanks toa all for having helped me so far.
Best regards
Pierre-André
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fdo-42286-do-not-shrink-the-filtered-area-when-calli.patch
Type: application/mbox
Size: 1093 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111124/84d0ee65/attachment.bin>