[Libreoffice] [PATCH] fdo#42286, do not shrink the selected area

[Eike Rathke]

Hi Pierre-André,

On Thursday, 2011-11-24 22:47:56 +0100, Pierre-André Jacquod wrote:

> here attached an new patch (hopefully wiser) to solve the mentioned
> bug. This  ensure that the call to ExtendDataArea does as commented
> in the code sc/source/core/tool/dbdata.cxx :
> // Extend the DB area to include data rows immediately below.
> and does not shrink the original area... So having a smaller area
> after the function is clearly wrong.
> 
> If you agree, I will push it to master.

Yes, that looks good, if it solves your problem then please go ahead.

> BUT this is a workaround, to compensate the not so correct behaviour
> of GetDataArea :-(

I wouldn't say it's wrong unless I checked the original intention behind
that code when GetDataArea() is called with bIncludeOld=false, maybe
it's just the call in ExtendDataArea() that should pass true instead?


> About the root cause: I am still studing the code of the both
> mentioned functions and their integration with filters and filtered
> areas. Before touching it, I would like to define what should be the
> desired effect. Further some tests have shown me that the behaviour
> (regarding area) is not the same, depending if the filter is
> activated with Data->Filter->AutoFilter or Standard filter. I fear
> some parts will need to be quite overhauled.

And the difference exactly is ...?

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111125/8c7308b9/attachment-0001.pgp>