[Libreoffice] [Libreoffice-commits] .: solenv/gbuild

[Lubos Lunak]

On Wednesday 30 of November 2011, Bjoern Michaelsen wrote:
>  solenv/gbuild/extensions/post_BuildplTargets.mk |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> New commits:
> commit 1f538764acdd67c3f294cd03da006ace27f736ef
> Author: Bjoern Michaelsen <bjoern.michaelsen at canonical.com>
> Date:   Wed Nov 30 14:02:08 2011 +0100
>
>     make build.pl verbose on non-silent builds

 This does not work, the build is verbose regardless of any -s passed to make. 
Moreover I question the usefullness of having verbose build by default.

> diff --git a/solenv/gbuild/extensions/post_BuildplTargets.mk
> b/solenv/gbuild/extensions/post_BuildplTargets.mk index 7e9b898..cd3101d
> 100644
> --- a/solenv/gbuild/extensions/post_BuildplTargets.mk
> +++ b/solenv/gbuild/extensions/post_BuildplTargets.mk
> @@ -54,7 +54,7 @@ endif
>
>  gb_BuildplTarget_COMPLETEDTARGETS=
>  define gb_BuildplTarget_command
> -cd $(SRCDIR)/$(1) && unset MAKEFLAGS && $(SOLARENV)/bin/build.pl
> -P$(BUILD_NCPUS) $(2) -P$(GMAKE_PARALLELISM) gb_MAKETARGET=$(gb_MAKETARGET)
> +cd $(SRCDIR)/$(1) && unset MAKEFLAGS && $(SOLARENV)/bin/build.pl $(if
> $(filter s,$(MAKEFLAGS)),,VERBOSE=T) -P$(BUILD_NCPUS) $(2)
> -P$(GMAKE_PARALLELISM) gb_MAKETARGET=$(gb_MAKETARGET) $(eval
> gb_BuildplTarget_COMPLETEDTARGETS+=$(1))
>  endef

-- 
 Lubos Lunak
 l.lunak at suse.cz