[Libreoffice] [REVIEW] Speed up range name lookup from formula interpreter

[Eike Rathke]

Hi Kohei,

On Friday, 2011-09-02 17:13:22 -0400, Kohei Yoshida wrote:

> I'd like to have the attached patch reviewed and pushed to the -3-4
> branch.

That would also need
http://cgit.freedesktop.org/libreoffice/core/commit/?id=0bf8fd627afc8567ae8ec6fad8edf20a11f143ad

> It makes range name lookups by index a constant time which drastically
> improves formula calculation performance especially with documents with
> a larger number of named ranges.  This also improves the import
> performance of binary Excel documents since the xls import filter
> currently re-uses the range name storage to emulate shared formulas.

I didn't test with any Excel document yet to verify. Actually
I currently have zero original Excel documents ;) I'll have to copy the
testcase farm of the old OOo tree Daniel used to maintain [should do
that while they are still there..]

Apart from the anomalies and crashes I fixed I didn't encounter other
glitches.

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110905/d85a0f99/attachment-0001.pgp>