[Libreoffice] [REVIEW] Speed up range name lookup from formula interpreter

Eike Rathke ooo at erack.de
Mon Sep 5 12:51:14 PDT 2011


Hi Kohei,

On Sunday, 2011-09-04 20:09:30 -0400, Kohei Yoshida wrote:

> > I didn't test with any Excel document yet to verify. Actually
> > I currently have zero original Excel documents ;) I'll have to copy the
> > testcase farm of the old OOo tree Daniel used to maintain [should do
> > that while they are still there..]
> 
> Yup.  That would be very helpful for our future testing needs.  We
> actually keep our suite of test documents in
> 
> http://cgit.freedesktop.org/libreoffice/contrib/test-files/
> 
> but we need more test documents to cover more cases.  It would be nice
> to migrate Daniel's test documents into this repository.

Will do so later. Btw, this fetches them together with the
extraordinarily fine Excel Biff documentation Daniel created, plus some
website stuff to be ignored ;)

git svn clone https://svn.openoffice.org/svn/sc~webcontent


> > Apart from the anomalies and crashes I fixed I didn't encounter other
> > glitches.
> 
> Sounds good.  So, do you think that these two commits combined (my
> original and your fix) would be safe enough to be backported to the
> stable (3.4) branch, or ...?  What's your opinion?

I think so, yes, currently building libreoffice-3-4 branch to check.

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110905/ed36a2ae/attachment.pgp>


More information about the LibreOffice mailing list