[Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2

Korrawit Pruegsanusak detective.conan.1412 at gmail.com
Tue Sep 6 07:52:46 PDT 2011


Hello all,

On Tue, Sep 6, 2011 at 20:08, Niko Rönkkö <niko.ronkko at wippies.fi> wrote:
> Hi
>
>> Wonderful, great stuff - I have to apologize, the many whitespace
>> changes in the calc part of the patch are because of my substandard
>> mentoring - cleaned-up version of the first patch attached.
>
> I was in the belief that we shall use spaces instead of tabs.
>
> Corrected patches attached.

And please s/interger/integer ;)
Also, it seems that you haven't check the range of ishift yet, whether
it is between -48 and 48 (from your description), or it isn't
necessary? I don't have knowledge on this.
My last nitpick, what about the strings capitalization?

Best Regards,
-- 
Korrawit Pruegsanusak


More information about the LibreOffice mailing list