[Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2

Eike Rathke ooo at erack.de
Wed Sep 7 05:25:02 PDT 2011


Hi Korrawit,

On Tuesday, 2011-09-06 21:52:46 +0700, Korrawit Pruegsanusak wrote:

> And please s/interger/integer ;)

Did that in the commit.

> Also, it seems that you haven't check the range of ishift yet, whether
> it is between -48 and 48 (from your description), or it isn't
> necessary? I don't have knowledge on this.

Actually those don't have to be restricted and I implemented another
algorithm to support larger values.

> My last nitpick, what about the strings capitalization?

Also did that.

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110907/5e1491c4/attachment-0001.pgp>


More information about the LibreOffice mailing list