[Libreoffice] [REVIEW] cherry-pick to 3-4: fix fdo#40590 defined names not resolved during file load

[Eike Rathke]

Hi Kohei,

On Tuesday, 2011-09-13 11:33:34 -0400, Kohei Yoshida wrote:

> However, while trying to re-create a test case for our unit test, I've
> discovered an issue.  I'd like to get your take on it.
> 
> Here is what I did.
> 
> 1. Create a new spreadsheet document.
> 2. Go to Insert - Names - Define
> 3. Create a new name MyName1 and assign "1+2" to it.  Push Add to add
> this name, but don't close the dialog yet.
> 4. Create a new name MyName2 and assign "MyName1*10".  Push Add to add
> this name.
> 5. MyName2 becomes myname1*10 (all lowercase), which is a sign that the
> name compilation has failed.
> 
> Having said this, this problem already exists before your changes, so
> I'm fine cherry-picking these commits to at least fix the reported case.
> Let me do a little more review before making the final call.  The change
> is non-trivial, so I have to dig a little more to understand this code
> change...

Actually that problem exists in every version.. the reason is that the
new names exist only in the dialog's collection until one confirms the
dialog with OK, so the compiler doesn't find the name in the "real"
collection of the document/sheet. This could only be overcome by passing
the dialog's name collection to the compiler to make it known at that
step.

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110913/d68cfc1f/attachment.pgp>